Skip to content

Conversation

palday
Copy link
Member

@palday palday commented Aug 21, 2025

  • remove prfit!
  • place NLopt support in submodule. Placing NLopt support into a submodule will make it easier to move NLopt to an extension and promote PRIMA to the default backend.
  • Refactor profiling code so that it works with either backend.
  • update documentation on changing optimizer settings
  • update documentation on bounded optimization
  • add entry in NEWS.md

palday added 3 commits August 21, 2025 16:33
* Placing NLopt support into a submodule will make it easier to move NLopt to an extension and promote PRIMA to the default backend.
* Unfortunately, the profiling code still has been explicit assumptions around NLopt.
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.49%. Comparing base (42950ae) to head (f722e30).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/MixedModelsNLoptExt.jl 90.90% 2 Missing ⚠️
src/optsummary.jl 0.00% 2 Missing ⚠️
ext/MixedModelsPRIMAExt.jl 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   96.27%   95.49%   -0.79%     
==========================================
  Files          38       38              
  Lines        3654     3708      +54     
==========================================
+ Hits         3518     3541      +23     
- Misses        136      167      +31     
Flag Coverage Δ
current 95.17% <91.52%> (-0.78%) ⬇️
minimum 95.49% <91.52%> (-0.79%) ⬇️
nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

palday and others added 14 commits August 21, 2025 17:00
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ats/MixedModels.jl into pa/optimizer-backend-abstraction
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ats/MixedModels.jl into pa/optimizer-backend-abstraction
@palday palday requested a review from dmbates August 22, 2025 05:28
Minor changes in grammar.
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. Thanks for your careful attention to detail.

I am beginning to think that my plan to change the fitlog to a TypedTables.Table or a Tables.MatrixTable might be more complicated than it is worth. The motivation was to use a single vector to store the information from the evaluations; push!ing the objective and merge!ing the parameter vector onto the end after each evaluation. That would save creating the tuples of parameter vectors and objective values. In retrospect I don't think it would be that much of a win and the implementation is rather complex.

Instead I will keep the fitlog struct as it is and add an optional extractor that does the conversion.

@palday palday merged commit bf4b8eb into main Aug 22, 2025
8 of 9 checks passed
@palday palday deleted the pa/optimizer-backend-abstraction branch August 22, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants